Add a mention for the host header in metrics headers labels doc #10172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
kind/enhancement
mmatur
approved these changes
Oct 17, 2023
ldez
approved these changes
Oct 18, 2023
traefiker
force-pushed
the
fix-metrics-headers-doc
branch
from
7e39e6b
to
1c8d47e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a mention to yeld about the special case of the
Hostheader, in regards to the metrics headers labels feature.Motivation
To document a special use case.
Related to #10169
More
Additional Notes
Co-authored-by: Baptiste Mayelle baptiste.mayelle@traefik.io