Fix host header mention in prometheus metrics doc #10502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
area/documentation
kind/bug/fix
|
Hello @MorphBonehunter, Thanks for opening this! As this is a fix, this PR should target the v2.11 branch, could you please rebase it? |
MorphBonehunter
force-pushed
the
fix-metrics-headers-doc
branch
from
b9e8e68
to
8679b55
Compare
|
Ohh...sorry...as this is an fix also for v3 i thought it must be master to "backport" it in all other versions. |
ldez
approved these changes
Mar 7, 2024
traefiker
force-pushed
the
fix-metrics-headers-doc
branch
from
8679b55
to
2801a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #10169 the mentioned workaround for missing host value in the header map was to use the
X-Forwarded-Hostheader instead.The doc addition PR #10172 however introduced the
X-Forwarded-Forheader which this PR fixes.Motivation
Correct the docs for other users.
More