-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce dropped v2 dynamic config #10355
Merged
traefiker
merged 1 commit into
traefik:v3.0
from
rtribotte:reintroduce-v2-dynamic-config
Jan 29, 2024
Merged
Reintroduce dropped v2 dynamic config #10355
traefiker
merged 1 commit into
traefik:v3.0
from
rtribotte:reintroduce-v2-dynamic-config
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b05e0c
to
a5be035
Compare
a5be035
to
f13578e
Compare
mmatur
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f13578e
to
5d07f57
Compare
nmengin
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
5d07f57
to
9486443
Compare
2 tasks
lbenguigui
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9486443
to
7589b13
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR alleviates the breaking changes done on the dynamic configuration.
It intends to allow support for deprecated options.
Warning logs have been introduced to warn about the deprecation when necessary.
The list of configuration options brought back and that will still be supported:
sslRedirect
optionsslTemporaryRedirect
optionsslHost
optionsslForceHost
optionfeaturePolicy
optionforceSlash
optionterminationDelay
optionautoDetect
optionThe list of configurations still parsed without breaking the configuration, but ineffective:
tls.CaOptional
optionpreferServerCipherSuites
optionMotivation
To ease migration to v3.
Related to #10260
Superseding #10335
Superseding #9600
More
Additional Notes
Co-authored-by: Baptiste Mayelle baptiste.mayelle@traefik.io