Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce dropped v2 dynamic config #10355

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

rtribotte
Copy link
Member

@rtribotte rtribotte commented Jan 17, 2024

What does this PR do?

This PR alleviates the breaking changes done on the dynamic configuration.
It intends to allow support for deprecated options.
Warning logs have been introduced to warn about the deprecation when necessary.

The list of configuration options brought back and that will still be supported:

  • IPWhiteList middleware
  • Headers middleware sslRedirect option
  • Headers middleware sslTemporaryRedirect option
  • Headers middleware sslHost option
  • Headers middleware sslForceHost option
  • Headers middleware featurePolicy option
  • StripPrefix middleware forceSlash option
  • Load-balancer terminationDelay option
  • Content-Type middleware autoDetect option

The list of configurations still parsed without breaking the configuration, but ineffective:

  • ForwardAuth middleware tls.CaOptional option
  • TLSOptions preferServerCipherSuites option

Motivation

To ease migration to v3.
Related to #10260
Superseding #10335
Superseding #9600

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Baptiste Mayelle baptiste.mayelle@traefik.io

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur force-pushed the reintroduce-v2-dynamic-config branch from f13578e to 5d07f57 Compare January 22, 2024 09:44
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@lbenguigui lbenguigui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the reintroduce-v2-dynamic-config branch from 9486443 to 7589b13 Compare January 29, 2024 16:10
@traefiker traefiker merged commit 40de310 into traefik:v3.0 Jan 29, 2024
22 checks passed
@rtribotte rtribotte deleted the reintroduce-v2-dynamic-config branch March 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature. priority/P1 need to be fixed in next release size/L
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants