Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the missing circuit-breaker response code for CRD #10625

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Apr 17, 2024

What does this PR do?

Adds the missing circuit-breaker response code for CRD.

Motivation

Be able to use the response code with CRD.
It was missing from the PR #10147.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Superseedes #10624

@fahhem
Copy link
Contributor

fahhem commented Apr 17, 2024

Thanks!

@ldez ldez changed the title Adds the missing response code for circuit-breaker for CRD Adds the missing circuit-breaker response code for CRD Apr 17, 2024
@fahhem
Copy link
Contributor

fahhem commented Apr 17, 2024

I can't approve the PR officially, so this is the best you can get from me: 👍

@rtribotte rtribotte self-assigned this Apr 18, 2024
@kevinpollet kevinpollet self-requested a review April 18, 2024 12:18
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtribotte rtribotte removed their assignment Apr 18, 2024
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 95312d5 into traefik:v3.0 Apr 19, 2024
22 checks passed
@ldez ldez deleted the fix/cb-response-code branch April 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants