-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty configuration for OpenTelemetry metrics and tracing #10729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
status/2-needs-review
kind/bug/fix
a bug fix
area/middleware/metrics
area/middleware/tracing
labels
May 16, 2024
ldez
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nmengin
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
kevinpollet
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
traefiker
force-pushed
the
fix-otlp-config
branch
from
May 21, 2024 08:26
9d55e33
to
c37777c
Compare
2 tasks
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 24, 2024
https://build.opensuse.org/request/show/1176684 by user weberho + anag+factory - Update to version 3.0.1 * CVEs: * CVE-2024-24788 (bsc#1224018): A malformed DNS message in response to a query can cause the Lookup functions to get stuck in an infinite loop. * Bug fixes: * [k8s/ingress] Fix rule syntax version for all internal routers (gh#traefik/traefik#10689 by HalloTschuess) * [metrics,tracing] Allow empty configuration for OpenTelemetry metrics and tracing (gh#traefik/traefik#10729 by rtribotte) * [provider,tls] Bump tscert dependency to 28a91b69a046 (gh#traefik/traefik#10668 by kevinpollet) * [rules,tcp] Fix the rule syntax mechanism for TCP (gh#traefik/traefik#10680 by lbenguigui) * [tls,server] Remove deadlines when handling PostgreSQL connections (gh#traefik/traefik#10675 by rtribotte) * [webui]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows empty configuration for OpenTelemetry metrics and tracing.
Motivation
Fixes #10721
More
Additional Notes