Use correct type when watching for k8s secrets #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
changed the title
|
Good catch, @kekoav -- thanks for the fix! @dtomcej @errm @emilevauge it seems like the problem is enough of a nuisance to justify going into a 1.3 patch release. Would you agree? |
|
@timoreimann makes sense! |
|
👍 @kekoav would you mind rebasing onto the v1.3 branch? We'll merge things back into master afterwards. |
timoreimann
approved these changes
Jun 2, 2017
dtomcej
approved these changes
Jun 2, 2017
…ret watcher traefik#1596 This was likely just a copy-paste issue, the bug should be benign because the secret is cast to the correct type later, but the additional logging is a major annoyance, and is happening even if basic auth is not in use with Kubernetes.
|
@timoreimann I cherry-picked the fix onto 1.3 branch, and changed the PR to target the v1.3 branch. |
|
@kekoav thanks for taking care! 💐 I was a little bit overloaded and couldn't pay enough attention to this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was likely just a copy-paste issue, the bug should be benign because the secret is cast to the correct type later, but the additional logging is a major annoyance, and is happening even if basic auth is not in use with Kubernetes.
Description