New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all available annotations to k8s Backend #2612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's one point where our homogenization might not be good: IMHO, Traefik health checks make no sense with Kubernetes since readiness probes are supposed to take care of this. There's a high chance that if both are enabled, users will be confused because the Endpoints controller may remove a pod from rotation while Traefik still wants to health-check it, leading to weird error messages.
@dtomcej @errm can you think of a use case where it makes sense to support both?
0aa74a8
to
0e6c9ee
Compare
0e6c9ee
to
3f815fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
d32d9b6
to
19e2680
Compare
4b84c73
to
91a7111
Compare
@timoreimann @ldez If we are constructing backends by parsing service endpoints, then that endpoint list already takes into account pod readiness and liveliness probes. I agree that introducing an independent/redundant health check would be confusing and indeed cause lifecycle issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of the h/c issue discussed,
LGTM
91a7111
to
176de2a
Compare
I removed the health check. |
a75129c
to
e85c6de
Compare
cb4826d
to
1ac89f3
Compare
1ac89f3
to
487e32f
Compare
fix(k8s): redirection template.
487e32f
to
726c769
Compare
What does this PR do?
Motivation
Homogenization of the providers [part2]: all providers must have the same options available.
More
Additional Notes
Several PRs will come after that for each provider.
Related to #618, #1465
Closes #2783