Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirection: permanent move option. #2774

Merged
merged 2 commits into from Jan 31, 2018
Merged

Redirection: permanent move option. #2774

merged 2 commits into from Jan 31, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 27, 2018 •
edited

What does this PR do?

Add permanent move options for redirect.

Motivation

Fixes #671, #2666

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

For k8s, I'm waiting the merge of #2612

@ldez ldez added this to the 1.6 milestone Jan 27, 2018
@ldez ldez requested review from a team as code owners January 27, 2018 16:51
@ldez ldez force-pushed the feature/permanent-redirect branch from c1fd7fc to 5f035ae Compare January 27, 2018 16:56
@ldez ldez force-pushed the feature/permanent-redirect branch from 5f035ae to 7fa06db Compare January 28, 2018 14:03
@funkyfuture
Copy link
Contributor

thanks for implementing. how would a default be configured in the [docker] section of the traefik.toml?

@ldez
Copy link
Member Author

ldez commented Jan 29, 2018

@funkyfuture This feature is not provider dependent.

The redirection can be define on entry point or frontend and with labels/annotations on containers/services.

juliens
juliens approved these changes Jan 29, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

@ldez ldez force-pushed the feature/permanent-redirect branch 3 times, most recently from a925c77 to 7dfeda5 Compare January 31, 2018 16:25
@ldez ldez force-pushed the feature/permanent-redirect branch from 7dfeda5 to 8764d9d Compare January 31, 2018 16:32
@ldez ldez requested a review from a team as a code owner January 31, 2018 16:32
@ldez ldez removed the bot/no-merge label Jan 31, 2018
mmatur
mmatur approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

dtomcej
dtomcej approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez removed the bot/no-merge label Jan 31, 2018
@traefiker traefiker merged commit 58d6681 into traefik:master Jan 31, 2018
@ldez ldez deleted the feature/permanent-redirect branch January 31, 2018 18:10
@samvdb samvdb mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@dtomcej dtomcej dtomcej approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/middleware area/provider kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ldez @funkyfuture @juliens @mmatur @nmengin @dtomcej @traefiker