Change boolean annotation values to string #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
approved these changes
Feb 12, 2018
There was a problem hiding this comment.
Good catch, thanks. 👏
This should go into the v1.5 branch first perhaps. I'll let @ldez decide.
errm
approved these changes
Feb 12, 2018
There was a problem hiding this comment.
LGTM... @timoreimann agreed that it should go into the release branch also
|
My main problem is that the documentation on this part has been completely rewritten in master. |
Kubernetes annotation values must be strings. Booleans and numbers are not valid types. Unfortunately no clear documentation exists stating this. [Annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) [Annotations have same requirements as labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) [GetAnnotations accessor returns string map](https://github.com/kubernetes/kubernetes/blob/f5f6f3e715cb8dfbd9657a4229c77ec6a5eab135/staging/src/k8s.io/apimachinery/pkg/api/meta/meta.go#L583) Formatting to add space between colon and value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update annotations documentation
Motivation
Kubernetes annotation values must be strings.
Booleans and numbers are not valid types.
Unfortunately no clear upstream documentation exists stating this.
More
Additional Notes
Kubernetes annotation values must be strings. Booleans and numbers are not valid types. Unfortunately no clear upstream documentation exists stating this.
Annotations
Annotations have same requirements as labels
GetAnnotations accessor returns string map
Formatting to add space between colon and value.