New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change boolean annotation values to string #2839

Merged

traefiker merged 1 commit into traefik:master from hobti01:patch-1

Feb 16, 2018

Commits on Feb 16, 2018

Change boolean annotation values to string

Kubernetes annotation values must be strings.  Booleans and numbers are not valid types.  Unfortunately no clear documentation exists stating this.
[Annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/)
[Annotations have same requirements as labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set)
[GetAnnotations accessor returns string map](https://github.com/kubernetes/kubernetes/blob/f5f6f3e715cb8dfbd9657a4229c77ec6a5eab135/staging/src/k8s.io/apimachinery/pkg/api/meta/meta.go#L583)

Formatting to add space between colon and value.

hobti01 authored and traefiker committed Feb 16, 2018