Toggle /ping to artificially return unhealthy responses on SIGTERM during requestAcceptGraceTimout interval #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravilr
force-pushed
the
graceful_rotation
branch
from
8e6863b
to
ca3e806
Compare
|
@marco-jantke Updated the ping.md documentation. Please review. |
|
@ldez this pr is against 1.5 branch. should i open a pr against master branch also? Please let me know. |
|
@ravilr could you rebase on master. |
…ring requestAcceptGraceTimout interval rebase to master rebase to master
ravilr
force-pushed
the
graceful_rotation
branch
from
663debb
to
9207970
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhance /ping handler to return non-200 response upon requestAcceptGraceTimeout initiation, iff it is set.
Motivation
Fixes #2969