Toggle /ping to artificially return unhealthy response on SIGTERM during requestAcceptGraceTimeout interval #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ldez @marco-jantke please triage and review. |
juliens
added
status/2-needs-review
area/healthcheck
and removed
status/0-needs-triage
labels
emilevauge
requested changes
Mar 22, 2018
docs/configuration/ping.md
Outdated
|
|
||
| ### Using ping for external Load-balancer rotation health check | ||
|
|
||
| If you are running traefik behind a external Load-balancer, and want to configure rotation health check on the Load-balancer to take a traefik instance out of rotation gracefully, you can configure [lifecycle.requestAcceptGraceTimeout](https://github.com/containous/traefik/blob/master/docs/configuration/commons.md#life-cycle) and the ping endpoint will return `503` response on traefik server termination, so that the Load-balancer can take the terminating traefik instance out of rotation, before it stops responding. |
There was a problem hiding this comment.
https://github.com/containous/traefik/blob/master/docs/configuration/commons.md#life-cycle should be a relative link
…ing requestAcceptGraceTimout interval
traefiker
force-pushed
the
graceful_rotation2
branch
from
10ded78
to
5eb7787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhance /ping handler to return non-200 response upon requestAcceptGraceTimeout initiation, iff it is set.
Motivation
Fixes #2969
More
Additional Notes
this is same as abandoned #3031, but rebased against master branch.