Metrics: Add support for InfluxDB Database / RetentionPolicy and HTTP client #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
drewkerrigan
commented
May 28, 2018
metrics/influxdb.go
Outdated
| } else { | ||
| log.Warnf("Unsupported protocol: %s, defaulting to udp") | ||
| default: | ||
| log.Warnf("Unsupported protocol: %s, defaulting to udp.", config.Address) |
There was a problem hiding this comment.
Should be
log.Warnf("Unsupported protocol: %s, defaulting to udp.", config.Protocol)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
types.InfluxDBProtocol: Defaults to"udp", can also be"http"Database,RetentionPolicy: Allows specification of database and RP when protocol is"http"(UDP client does not support queries)net/http/httptest/ channel based test similar to the existing udp based test in metrics/influxdb_test.goMotivation
The InfluxDB UDP endpoint does not support choosing a database, so environments that have many datasources for InfluxDB generally need the ability to separate influx data into multiple databases.
More
Additional Notes
One of the more bigger changes here is the fact that it attempts to create a database if an error is encountered containing the message
"database not found". This is a nice to have, (but not required) feature present in other similar applications (like telegraf -> https://github.com/influxdata/telegraf/blob/master/plugins/outputs/influxdb/influxdb.go#L209-L215 for example).