Add HTTP authentication to influxdb metric backend #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
traefiker
force-pushed
the
influx-http-login
branch
from
17f5652
to
bcb6d24
Compare
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add some configuration options and corresponding structures to pass
usernameandpasswordto theinfluxdbmetric backend. These options are only usable with HTTP and NOT with the UDP configuration.Motivation
Passwords are good for security I guess? Also I needed it for my work and it was easily implemented as the HTTP backend was ready since #3391.
More
Additional Notes
Built and tested, apparently traefik doesn't report metrics when there is no request. Is that by design? Other influxdb colletors (such as
telegraf) usually report one record per second for each metrics.