Add segments to the consulcatalog provider #3781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2018
Closed
mmatur
added
status/2-needs-review
kind/enhancement
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds segments to the consulcatalog provider. It does this in the same way as the docker provider does.
Motivation
#3597
We are facing the issue that our consul services have routes for multiple domains and share the fqdn between services. This means we would need more than one
ruleto express the routes for each service. This PR enables us to do so.More
Additional Notes
I implemented the segments using the existing
label.ExtractTraefikLabels. I envision that the frontends which are the result of one single service have both the original service name and the segment name in their name: traefik.rule1.frontend.rule:*** on servicemyserviceleads to a frontend named frontend-myservice-rule1. All the frontends which are generated out of a service, share the same backend, to minimise resources. For this I needed to adjustgetServiceBackendNameto use the original service name as a name, which I store inserviceUpdate.ParentServiceName.I added a test that expands a single service into 2 frontends, by having 2 segments.