Multiple frontends for consulcatalog #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mmatur
requested changes
Aug 22, 2018
| @@ -151,6 +151,12 @@ Additional settings can be defined using Consul Catalog tags. | |||
| | `<prefix>.frontend.whiteList.sourceRange=RANGE` | Sets a list of IP-Ranges which are allowed to access.<br>An unset or empty list allows all Source-IPs to access. If one of the Net-Specifications are invalid, the whole list is invalid and allows all Source-IPs to access. | | |||
| | `<prefix>.frontend.whiteList.useXForwardedFor=true` | Uses `X-Forwarded-For` header as valid source of IP for the white list. | | |||
|
|
|||
| ### Multiple frontends for a single service | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| Attributes: service.Attributes, | ||
| TraefikLabels: service.TraefikLabels, | ||
| }) | ||
| // loop over children of <prefix>.frontends.* |
There was a problem hiding this comment.
Could you add a new line before please
| TraefikLabels: frontend.Labels, | ||
| }) | ||
| } | ||
| return frontends |
There was a problem hiding this comment.
Could you add a new line before please
| } | ||
| func getSegments(path string, prefix string, tree map[string]string) []*frontendSegment { | ||
| segments := make([]*frontendSegment, 0) | ||
| // FIXME: do this more efficient.. |
There was a problem hiding this comment.
Could you please rename this FIXME
| segmentNames[strings.SplitN(strings.TrimPrefix(key, path+"."), ".", 2)[0]] = true | ||
| } | ||
| } | ||
| // get labels for each segment found |
There was a problem hiding this comment.
Could you add a new line before please
| Labels: labels, | ||
| }) | ||
| } | ||
| return segments |
There was a problem hiding this comment.
Could you add a new line before please
|
Reformatted as requested, thanks for your review! |
mmatur
added
kind/enhancement
mmatur
force-pushed
the
consulcatalog-segmentation
branch
2 times, most recently
from
8853766
to
1d810d0
Compare
ldez
changed the title
ldez
approved these changes
Aug 27, 2018
traefiker
force-pushed
the
consulcatalog-segmentation
branch
from
1d810d0
to
2c0fbc1
Compare
|
Thanks for the merge! |
This was referenced Aug 28, 2018
juliens
changed the title
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#3597
We are facing the issue that our consul services have routes for multiple domains and share the fqdn between services. This means we would need more than one
ruleto express the routes for each service. This PR enables us to do so.More
Additional Notes
This is probably better implemented as an 'OR' for route rules. However, with the upcoming rewrite of the route rule syntax, this will have to wait. This PR implements segments on frontends for the consul catalog provider. It allows to create multiple frontends per service.