Add RequestPathRaw and RequestQuery #4162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. Sorry for the late answer. Could you rebase this pull request on v2.0 branch? |
|
I have to close this one because of its lack of activity 😞 Feel free to re-open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RequestPathRawandRequestQueryMotivation
This pr is addressing to #4142 I want to make log processing as simple as possible, and for this I want to introduce two addition fields in accesses logs
RequestPathRawandRequestQuerythat splitRequestPathon path and query respectively. The best solution would be to extract query fromRequestPathbut it would introduce breaking change. But if it acceptable I will rewrite pr.More
Additional Notes