Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a log fields documentation. #4890

Merged
merged 2 commits into from May 21, 2019
Merged

Adds a log fields documentation. #4890

merged 2 commits into from May 21, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented May 20, 2019 •
edited

What does this PR do?

Adds a log fields documentation.

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Extracted from #4162

@traefiker traefiker added this to the 1.7 milestone May 20, 2019
mmatur
mmatur approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 7722a41 into traefik:v1.7 May 21, 2019
@ldez ldez deleted the fix/doc-log-fields branch May 21, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/logs kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @mmatur @dtomcej @traefiker