Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded DD APM library #4189

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Upgraded DD APM library #4189

merged 1 commit into from
Nov 15, 2018

Conversation

aantono
Copy link
Contributor

@aantono aantono commented Nov 12, 2018

Upgraded DD APM library to the latest version.

@ldez
Copy link
Contributor

ldez commented Nov 12, 2018

@aantono Hello, could you give more information about this update?

@aantono
Copy link
Contributor Author

aantono commented Nov 12, 2018

There have been a number of bug fixes related to the payload and sampling that improve performance and memory usage. (for example DataDog/dd-trace-go#319, DataDog/dd-trace-go#264, DataDog/dd-trace-go#322, DataDog/dd-trace-go#326 to name a few of the more interesting/important ones). The version Traefik currently uses is the initial 1.0.0 release, which has been refined since the initial publishing to remove bugs and fine-tune functionality. It is a backwards compatible upgrade, and we have not observed any undesired behavior from the new version.

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants