ddtrace/tracer: support int64 ids for the text map reader #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
added a commit
to artsy/dd-trace-rb
that referenced
this pull request
Sep 2, 2018
This is what dd-trace-js sends over the wire: https://github.com/DataDog/dd-trace-js/blob/aa607860ea6bb57f2f69fa7ee72ed3ce25abfbf6/src/opentracing/propagation/text_map.js#L14-L15 It’s also what has been patched in e.g. dd-trace-go: DataDog/dd-trace-go#326
alloy
added a commit
to artsy/dd-trace-rb
that referenced
this pull request
Sep 2, 2018
This is what dd-trace-js sends over the wire: https://github.com/DataDog/dd-trace-js/blob/aa607860ea6bb57f2f69fa7ee72ed3ce25abfbf6/src/opentracing/propagation/text_map.js#L14-L15 It’s also what has been patched in e.g. dd-trace-go: DataDog/dd-trace-go#326
gbbr
approved these changes
Sep 10, 2018
ddtrace/tracer/util_test.go
Outdated
| assert.NoError(t, err) | ||
| assert.Equal(t, uint64(9637668538106313706), id) | ||
| }) | ||
| t.Run("positive", func(t *testing.T) { |
There was a problem hiding this comment.
Would you mind adding a blank line between these tests? We've done the same everywhere else.
alloy
added a commit
to artsy/dd-trace-rb
that referenced
this pull request
Sep 10, 2018
This is what dd-trace-js sends over the wire: https://github.com/DataDog/dd-trace-js/blob/aa607860ea6bb57f2f69fa7ee72ed3ce25abfbf6/src/opentracing/propagation/text_map.js#L14-L15 It’s also what has been patched in e.g. dd-trace-go: DataDog/dd-trace-go#326
gbbr
pushed a commit
that referenced
this pull request
Sep 11, 2018
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For distributed tracing some languages are passing through int64s instead of uint64s. It's fairly straightforward to support both.