Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include lint in build process #4462

Merged
merged 1 commit into from Feb 5, 2019
Merged

Include lint in build process #4462

merged 1 commit into from Feb 5, 2019

Conversation

Slashgear
Copy link
Contributor

What does this PR do?

  • Fix lint issues with current lint configuration
  • include lint in webui docker image

Motivation

  • lint is here to protect contributor to add dead code or to break some code styling rules. (we are not in a really typed world here 馃ぃ )

Additional Notes

@ldez ldez added this to the next milestone Feb 4, 2019
ldez
ldez approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Slashgear Slashgear mentioned this pull request Feb 4, 2019
Merged
mmatur
mmatur approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geraldcroes
geraldcroes approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 54ca0ce into traefik:master Feb 5, 2019
@ldez ldez changed the title chore(lint): include lint in build process Include lint in build process Mar 15, 2019
@ldez ldez added kind/enhancement a new or improved feature. and removed area/provider/docker labels Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/webui kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Slashgear @geraldcroes @mmatur @ldez @traefiker