Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code with prettier #4463

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Format code with prettier #4463

merged 1 commit into from
Feb 5, 2019

Conversation

Slashgear
Copy link
Contributor

@Slashgear Slashgear commented Feb 4, 2019 •
edited

What does this PR do?

  • linked to Include lint in build process #4462 ⚠️ Do not merge without being rebased on the other PR
  • add Prettier support in webui code (Typescript, Javascript, HTML, Markdown)
  • add formatting check in build

Motivation

  • Code formatting is a great tool. In web env we don't have an official "go fmt" support. We often use a code formatter linked to a code linter to check code format.

Additional Notes

@Slashgear Slashgear changed the title Webui format code chore(webui): format code with prettier Feb 4, 2019
geraldcroes
geraldcroes approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the next milestone Feb 5, 2019
@traefiker traefiker merged commit c5c8382 into traefik:master Feb 5, 2019
@ldez ldez added the kind/enhancement a new or improved feature. label Mar 15, 2019
@ldez ldez changed the title chore(webui): format code with prettier Format code with prettier Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/webui kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Slashgear @geraldcroes @mmatur @ldez @traefiker