Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds TCP support #4587

Merged
merged 3 commits into from Mar 14, 2019
Merged

Adds TCP support #4587

merged 3 commits into from Mar 14, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Mar 14, 2019

What does this PR do?

Do we really need further explanations?

Motivation

Fix an old issue!

Fixes #10

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Yeah man!

Co-authored-by: Gérald Croës gerald@containo.us

juliens and others added 3 commits March 14, 2019 09:04
@juliens @geraldcroes
New protocol :)
70b9aa3 
Co-authored-by: Gérald Croës <gerald@containo.us>
@juliens @jbdoumenjou
Remove experimental feature
8f31178 
Co-authored-by: jbdoumenjou <jb.doumenjou@gmail.com>
@juliens
Temporary disable flaky test
f86221b
@juliens juliens requested review from a team as code owners March 14, 2019 08:13
@ldez ldez requested review from ldez and jbdoumenjou March 14, 2019 08:15
ldez
ldez approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Mar 14, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM YOU BEAST! 👼

jbdoumenjou
jbdoumenjou approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@traefiker traefiker merged commit 4a68d29 into traefik:master Mar 14, 2019
@lexicoder
Copy link

Awesome!!!

@gaui
Copy link

gaui commented Mar 14, 2019

Wow awesome!

@bbinet bbinet mentioned this pull request Mar 14, 2019
Merged
@kiwi-dejero
Copy link

Oh Boy Oh Boy Oh Boy !!

@ldez ldez changed the title Add a new protocol Add TCP support Mar 18, 2019
@ldez ldez changed the title Add TCP support Adds TCP support Mar 18, 2019
@ldez ldez added area/tcp and removed area/server labels Mar 18, 2019
@natcl natcl mentioned this pull request Mar 19, 2019
Closed
@mariusfa

This comment has been minimized.

Sign in to view
@llitfkitfk
Copy link

Great!!!

@timoschwarzer timoschwarzer mentioned this pull request May 17, 2019
Closed
@benyanke
Copy link

AWESOME.

@Asherslab Asherslab mentioned this pull request Jun 9, 2019
Closed
@Sirtea Sirtea mentioned this pull request Jun 27, 2019
Closed
@shantanugadgil
Copy link

This is genuinely awesome work!!!! Great job!!! 🥇 💯

@kidpixo kidpixo mentioned this pull request Jul 14, 2019
Open
@jacobtomlinson jacobtomlinson mentioned this pull request Jul 26, 2019
Merged
@juliens juliens deleted the tcp branch September 6, 2019 05:39
@grubyhs

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbinet bbinet bbinet left review comments

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

@geraldcroes geraldcroes Awaiting requested review from geraldcroes

Assignees
No one assigned
Labels
area/tcp kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

TCP support