Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rule HostSNI in documentation #4592

Merged
merged 1 commit into from Mar 14, 2019
Merged

Use rule HostSNI in documentation #4592

merged 1 commit into from Mar 14, 2019

Conversation

bbinet
Copy link
Contributor

@bbinet bbinet commented Mar 14, 2019

What does this PR do?

Address documentation fix as proposed in #4587 (review)

@bbinet bbinet mentioned this pull request Mar 14, 2019
Merged
2 tasks
geraldcroes
geraldcroes approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You (LGTM)

@ldez ldez added area/documentation status/2-needs-review bot/light-review decreases the number of required LGTM from 3 to 1. and removed status/0-needs-triage labels Mar 14, 2019
@ldez ldez added this to the next milestone Mar 14, 2019
@ldez ldez changed the title Docfix: use rule HostSNI for tcp routers Use rule HostSNI Mar 14, 2019
@ldez ldez changed the title Use rule HostSNI Use rule HostSNI in documentation Mar 14, 2019
@traefiker traefiker merged commit cfaf47c into traefik:master Mar 14, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Mar 14, 2019
@bbinet bbinet deleted the patch-1 branch March 14, 2019 11:21
@ldez ldez added the area/tcp label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

Assignees
No one assigned
Labels
area/documentation area/tcp kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbinet @geraldcroes @ldez @traefiker