Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds mirroring service #5251

Merged
merged 6 commits into from
Aug 26, 2019
Merged

Adds mirroring service #5251

merged 6 commits into from
Aug 26, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Aug 26, 2019

What does this PR do?

This PR adds a mirroring service.

Motivation

Be able to mirror traffic to others services.
Fixes #2989

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Aug 26, 2019
mmatur
mmatur requested changes Aug 26, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions otherwise SGTM

pkg/server/service/loadbalancer/mirror/mirror.go Outdated Show resolved Hide resolved
pkg/server/service/loadbalancer/mirror/mirror.go Outdated Show resolved Hide resolved
pkg/server/service/service_test.go Outdated Show resolved Hide resolved
pkg/server/service/service_test.go Show resolved Hide resolved
mmatur
mmatur approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl
mpl requested changes Aug 26, 2019
View reviewed changes
docs/content/routing/services/index.md Outdated Show resolved Hide resolved
pkg/server/service/loadbalancer/mirror/mirror.go Outdated Show resolved Hide resolved
pkg/server/service/loadbalancer/mirror/mirror.go Show resolved Hide resolved
pkg/server/service/loadbalancer/mirror/mirror.go Outdated Show resolved Hide resolved
ldez
ldez approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl
mpl approved these changes Aug 26, 2019
View reviewed changes
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 602a2ea into traefik:v2.0 Aug 26, 2019
@traefiker traefiker mentioned this pull request Aug 26, 2019
Closed
@juliens juliens deleted the mirror branch September 6, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomach jomach jomach left review comments

@ldez ldez ldez approved these changes

@mpl mpl mpl approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/server kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juliens @mpl @mmatur @jomach @ldez @traefiker