Rename the non-exposed field "count" to "size" #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylr
force-pushed
the
rename-crr-count
branch
from
cedba89
to
3a7a4d8
Compare
ldez
requested changes
Dec 17, 2019
There was a problem hiding this comment.
Hello,
The namecount is because this variable is used to count the number of byte already read.
At the end of the read, the number of byte read will be the size of the request body.
As it's an incremental thing, the name count is more appropriated than size for the captureRequestReader.
But for the request type the value is set only one time so the name size can be more appropriated.
So could to rename size to count for the captureRequestReader.
ldez
changed the title
ldez
changed the title
traefiker
force-pushed
the
rename-crr-count
branch
from
1d40d50
to
5ab3466
Compare
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
traefiker
force-pushed
the
rename-crr-count
branch
from
5ab3466
to
246e891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR renames a variable which name led to believe it contains a count whereas it contains a size.
Motivation
I've lost quite a bit of time while debuging thinking that
crr.countwas wrongly incremented.More
Additional Notes