Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add server up metrics #6461

Merged
merged 2 commits into from
Sep 26, 2020
Merged

Re-add server up metrics #6461

merged 2 commits into from
Sep 26, 2020

Conversation

coder-hugo
Copy link
Contributor

@coder-hugo coder-hugo commented Mar 10, 2020 •
edited
Loading

What does this PR do?

This PR re-adds the server up metric to traefik 2.x

Motivation

The server up metric is necessary for our setup

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@coder-hugo coder-hugo force-pushed the feature/re-add-server-up-metrics branch from b70ee42 to 4a88697 Compare March 10, 2020 09:32
@coder-hugo coder-hugo changed the title e add server up metrics Re-add server up metrics Mar 10, 2020
@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Mar 10, 2020
juliens
juliens requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏
Thanks for this PR and sorry for the delay to handle it!

Just some comments.

cmd/traefik/traefik.go Outdated Show resolved Hide resolved
pkg/server/router/router.go Outdated Show resolved Hide resolved
pkg/server/router/router.go Outdated Show resolved Hide resolved
pkg/server/router/router.go Outdated Show resolved Hide resolved
pkg/server/routerfactory.go Outdated Show resolved Hide resolved
pkg/server/routerfactory.go Outdated Show resolved Hide resolved
pkg/server/routerfactory.go Outdated Show resolved Hide resolved
pkg/server/routerfactory.go Outdated Show resolved Hide resolved
@coder-hugo coder-hugo force-pushed the feature/re-add-server-up-metrics branch 3 times, most recently from 6c0b4e0 to 5dc12d6 Compare July 2, 2020 12:45
@coder-hugo coder-hugo requested a review from juliens July 29, 2020 09:33
rtribotte
rtribotte approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ldez ldez added this to the next milestone Sep 24, 2020
@ldez ldez self-requested a review September 24, 2020 10:22
jbdoumenjou
jbdoumenjou approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtribotte rtribotte mentioned this pull request Sep 25, 2020
Closed
2 tasks
juliens
juliens approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the feature/re-add-server-up-metrics branch from 58e8cd7 to 968d849 Compare September 26, 2020 10:17
@ldez
Copy link
Contributor

ldez commented Sep 26, 2020

SemaphoreCI has a problem related to the change of the organization, I will have to close and then reopen your PR.
Sorry for the inconvenience

@ldez ldez closed this Sep 26, 2020
@ldez ldez reopened this Sep 26, 2020
@traefiker traefiker merged commit f2e53a3 into traefik:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@rtribotte rtribotte rtribotte approved these changes

@ldez ldez Awaiting requested review from ldez

Assignees
No one assigned
Labels
area/middleware/metrics kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
6 participants
@coder-hugo @ldez @juliens @jbdoumenjou @rtribotte @traefiker