Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add named port support to Kubernetes IngressRoute CRDs #7668

Merged
merged 6 commits into from
Jan 15, 2021
Merged

Add named port support to Kubernetes IngressRoute CRDs #7668

merged 6 commits into from
Jan 15, 2021

Conversation

cirrith
Copy link
Contributor

@cirrith cirrith commented Dec 15, 2020 •
edited
Loading

What does this PR do?

Convert the type of Kubernetes provider CRDs port variable from int32 to k8s IntOrString.

Motivation

Named ports are awesome as they don't force you to track all the specific port numbers.

Fixes #7560

More

  • Added/updated tests
  • Added/updated documentation

@cirrith cirrith mentioned this pull request Dec 15, 2020
Closed
SantoDE
SantoDE requested changes Dec 30, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I played with it for a bit and it works great.

I only have 1 tiny request to change for now :)

docs/content/routing/providers/kubernetes-crd.md Outdated Show resolved Hide resolved
@ldez ldez self-requested a review December 30, 2020 19:56
SantoDE
SantoDE approved these changes Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome stuff 👼

rtribotte
rtribotte approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added the kind/enhancement a new or improved feature. label Jan 14, 2021
@ldez ldez added this to the next milestone Jan 14, 2021
ldez
ldez approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bbee63f into traefik:master Jan 15, 2021
@stipo42
Copy link

stipo42 commented Apr 30, 2021

Hello, I see this is merged and in master but none of the recent Traefik 2.* releases contain the fix.
When can we expect this fix in the official releases for Traefik?

@ldez
Copy link
Contributor

ldez commented Apr 30, 2021

Hello, it will be a part of the next release (v2.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/crd area/provider/k8s kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

IngressRoute service support named port
7 participants
@cirrith @stipo42 @ldez @SantoDE @rtribotte @kevinpollet @traefiker