Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elaborate on possible use of status codes with the errors middleware #8176

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Elaborate on possible use of status codes with the errors middleware #8176

merged 3 commits into from
Jun 8, 2021

Conversation

Midnighter
Copy link
Contributor

What does this PR do?

  1. The make commands for building and serving the documentation seemed out of date to me so I briefly updated them.
  2. The current documentation on error pages was a bit brief for my taste which caused me to ask for clarification on the discussion board. I have expanded it to describe the full range of possible status combinations.

Motivation

This comment on my question.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.4 milestone Jun 7, 2021
rtribotte
rtribotte approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

jbdoumenjou
jbdoumenjou approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Midnighter @jbdoumenjou
docs: update to latest make commands
d388313
@Midnighter @jbdoumenjou
docs: extend possible examples for status codes
a7eb961 
The errors middleware allows very flexible status configuration which
was not clear from the existing documentation.
dtomcej
dtomcej approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 521fed1 into traefik:v2.4 Jun 8, 2021
@Midnighter Midnighter deleted the docs-errors-status branch June 8, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware size/S
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Midnighter @jbdoumenjou @dtomcej @rtribotte @ldez @traefiker