Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align docker configuration example notes in basicauth HTTP middleware #8615

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

tomMoulard
Copy link
Member

What does this PR do?

This PR aligns notes in both docker examples for the basic auth HTTP middleware.

Motivation

Have a unified documentation for both examples.

Fixes #8614

More

- [ ] Added/updated tests

  • Added/updated documentation

@tomMoulard tomMoulard added this to the 2.5 milestone Dec 7, 2021
@tomMoulard tomMoulard linked an issue Dec 7, 2021 that may be closed by this pull request
2 tasks
@tomMoulard tomMoulard changed the title doc: align docker configuration example notes in basicauth HTTP middl… doc: align docker configuration example notes in basicauth HTTP middleware Dec 7, 2021
@tomMoulard tomMoulard added bot/light-review decreases the number of required LGTM from 3 to 1. kind/bug/fix a bug fix and removed kind/enhancement a new or improved feature. labels Dec 7, 2021
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1c9e4c6 into traefik:v2.5 Dec 7, 2021
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Dec 7, 2021
@tomMoulard tomMoulard deleted the doc-docker-basichauth-align branch December 7, 2021 10:12
@tomMoulard tomMoulard changed the title doc: align docker configuration example notes in basicauth HTTP middleware docs: align docker configuration example notes in basicauth HTTP middleware Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note about BasicAuth usersFile NOT needing to escape dollar signs ($)
3 participants