Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default mode for fields.names to access log #8933

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Add default mode for fields.names to access log #8933

merged 2 commits into from
Apr 15, 2022

Conversation

aleksvujic
Copy link
Contributor

What does this PR do?

Fixed documentation formatting for default values of access log fields.

Motivation

I found out that documentation was formatted incosistently.

More

  • Added/updated tests
  • Added/updated documentation

@kevinpollet kevinpollet added the kind/bug/fix a bug fix label Apr 13, 2022
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kevinpollet kevinpollet changed the title Fixed format of default mode for access log field Fix format of default mode for access log fields Apr 13, 2022
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@kevinpollet kevinpollet added kind/enhancement a new or improved feature. and removed kind/bug/fix a bug fix bot/no-merge labels Apr 15, 2022
@kevinpollet kevinpollet changed the title docs: fix format of default mode for access log fields docs: add default mode for fields.names to access log Apr 15, 2022
@traefiker traefiker merged commit 78822a8 into traefik:v2.6 Apr 15, 2022
@kevinpollet kevinpollet changed the title docs: add default mode for fields.names to access log Add default mode for fields.names to access log Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants