-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default mode for fields.names to access log #8933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
added
area/documentation
status/2-needs-review
area/logs
and removed
status/0-needs-triage
labels
Apr 13, 2022
mpl
reviewed
Apr 13, 2022
kevinpollet
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
mpl
approved these changes
Apr 13, 2022
kevinpollet
changed the title
Fixed format of default mode for access log field
Fix format of default mode for access log fields
Apr 13, 2022
tomMoulard
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
ldez
changed the title
Fix format of default mode for access log fields
docs: fix format of default mode for access log fields
Apr 14, 2022
ldez
added
bot/no-merge
status/3-needs-merge
and removed
status/3-needs-merge
bot/need-human-merge
bot/no-merge
labels
Apr 14, 2022
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
kevinpollet
added
kind/enhancement
a new or improved feature.
and removed
kind/bug/fix
a bug fix
bot/no-merge
labels
Apr 15, 2022
kevinpollet
changed the title
docs: fix format of default mode for access log fields
docs: add default mode for fields.names to access log
Apr 15, 2022
kevinpollet
changed the title
docs: add default mode for fields.names to access log
Add default mode for fields.names to access log
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed documentation formatting for default values of access log fields.
Motivation
I found out that documentation was formatted incosistently.
More