Add OpenTelemetry tracing and metrics support #8999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomMoulard
added
kind/enhancement
rtribotte
reviewed
May 23, 2022
rtribotte
reviewed
May 23, 2022
rtribotte
reviewed
May 23, 2022
rtribotte
reviewed
May 23, 2022
kevinpollet
force-pushed
the
otlp
branch
7 times, most recently
from
f9e52d8
to
fb6faef
Compare
2 tasks
|
Would be great to get this PR merged. |
mpl
reviewed
Nov 15, 2022
kevinpollet
force-pushed
the
otlp
branch
5 times, most recently
from
e324bd3
to
50669a4
Compare
mpl
approved these changes
Nov 21, 2022
tomMoulard
force-pushed
the
otlp
branch
3 times, most recently
from
825a049
to
b799956
Compare
* Support OpenTelemetry tracing * Support OpenTelemetry metrics * Handle trace propagation
|
@tomMoulard thanks a lot for the PR, I am trying to deploy this in my k8 cluster where otel collector is running like a daemonset, not sure how to pass in the node ip to the command line args ? |
|
also if we are using aws xray as tracing backend, how can we change the trace id to xray specific ID ? for instance in our downstream services we use https://www.npmjs.com/package/@opentelemetry/id-generator-aws-xray |
|
Hello @jayasai470, Closed PRs are not a place to have discussions. Feel free to open a topic on Traefik's community forum. |
|
Thanks for letting me know, have created one https://community.traefik.io/t/traefik-opentelemetry/16994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support OpenTelemetry traces and metrics.
Motivation
To have more tracing and metrics backends.
Fixes #6374
Fixes #8231
More
Additional Notes
TODO: Handle W3C Trace Context propagation #8231