-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IPv6 addr with square brackets #9313
Fix IPv6 addr with square brackets #9313
Conversation
hello, can you prefer FYI, the PRs are automatically squashed and rebased when we merge a PR, you just have to rebase if your PR has conflicts. |
By default, you don't need to rebase or update your PR. |
Thank you. I will do better next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fix the function
parseHost
got different result from the host[ipv6Address]
and the host[ipv6Address]:8000
Motivation
I have set the entryPoint on the port 80. And a router rule set as
Host(
ipv6address)
.Send a request by curl :
curl http://[ipv6address]/
,I found theRequestDecorator
parse the host to[ipv6address]
.I try to set the port to 8080, and do
curl http://[ipv6address]:8080/
. TheRequestDecorator
parse the host toipv6address
.More
updated documentation