Support gRPC and gRPC-Web protocol in metrics #9483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
force-pushed
the
feature/grpc-code-metrics
branch
2 times, most recently
from
66ed12a
to
106cb35
Compare
kevinpollet
added
area/middleware/metrics
kind/enhancement
rtribotte
force-pushed
the
feature/grpc-code-metrics
branch
from
2439d30
to
e22371b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
grpc,grpcwebas a protocol to metrics when incoming request is a gRPC or gRPC-Web request and use gRPC Code instead of HTTP Status forcode.Motivation
To enhance gRPC, gRPC-Web metrics.
Supersedes #9415
More
[ ] Added/updated tests[ ] Added/updated documentationAdditional Notes
Sample prometheus metrics