Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gRPC and gRPC-Web protocol in metrics #9480

Closed
wants to merge 2 commits into from
Closed

Support gRPC and gRPC-Web protocol in metrics #9480

wants to merge 2 commits into from

Conversation

longit644
Copy link
Contributor

@longit644 longit644 commented Oct 28, 2022

What does this PR do?

Add grpc, grpcweb as a protocol to metrics when incoming request is a gRPC or gRPC-Web request and use gRPC Code instead of HTTP Status for code.

Motivation

To enhance gRPC, gRPC-Web metrics.

Supersedes #9415

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

Sample prometheus metrics

traefik_router_request_duration_seconds_bucket{code="Unauthenticated",method="POST",protocol="grpc",router="...",service="...",le="0.005"} 2

@kevinpollet
Copy link
Member

kevinpollet commented Oct 28, 2022

Hello @longit644,

Thanks for opening the pull request,

We rebased the pull request but we are unable to push those commits because of missing rights. Our CI tools will also not work properly because of those missing rights.

This is because you forked your organization repository which makes your personal fork inherits the organization's fork rights.

Please could you do the following:

  1. delete your current fork (https://github.com/longit644/traefik)
  2. create a new Traefik fork from the Traefik repository (https://github.com/traefik/traefik/fork)
  3. push your local branch to this new fork
  4. open a new pull request

@longit644
Copy link
Contributor Author

Hello @kevinpollet,

Thanks for your guide. I opened a new pull request here: #9483.

@ldez ldez removed the breaking label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants