Allow short healthcheck interval with long timeout #9832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
area/documentation
status/2-needs-review
kind/bug/fix
ldez
force-pushed
the
healthcheck-interval-remove-restriction
branch
from
974838f
to
36d509e
Compare
Previously, a healthcheck's interval was required to be longer than its timeout. Removing this restriction allows configuring frequent healthchecks against endpoints that may, at times, be slow to respond.
traefiker
force-pushed
the
healthcheck-interval-remove-restriction
branch
from
7f752dc
to
7e46f48
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the restriction on healthchecks that requires the check interval to be longer than its timeout.
Fixes #9812
Motivation
I'd like to configure frequent healthchecks so that changes to health status are discovered quickly. However this currently requires the timeout to be short too. If a check endpoint is occassionally slow to respond, this can lead to false negatives. Ideally a longer timeout is allowed even when the interval is short.
More