New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode query semicolons #9943
Merged
Merged
Encode query semicolons #9943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
status/2-needs-review
kind/bug/fix
a bug fix
area/middleware
and removed
status/0-needs-triage
labels
Jun 9, 2023
lbenguigui
force-pushed
the
encode_semicolon
branch
from
June 9, 2023 15:00
66c63d4
to
a165b22
Compare
juliens
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmatur
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rtribotte
approved these changes
Jun 15, 2023
traefiker
force-pushed
the
encode_semicolon
branch
from
June 15, 2023 12:54
62d3781
to
1cfedd8
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements the behavior explained here, and that was originally targeted for v3.
To enable this behavior, the option
encodeQuerySemicolons
has been introduced on the entry point configuration.Motivation
To allow using un-encoded semicolons in query parameters without interpreting them as separators.
Related to #9164
More
Additional Notes
Co-authored-by: Romain rtribotte@users.noreply.github.com