-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interp: improve handling of methods defined on interfaces #1516
Merged
Commits on Feb 23, 2023
-
interp: improve handling of methods defined on interfaces
For methods defined on interfaces (vs concrete methods), the resolution of the method is necessarily delayed at the run time and can not be completed at compile time. The selectorExpr processing has been changed to correctly identify calls on interface methods which were confused as fields rather than methods (due to the fact that in a interface definition, methods are fields of the interface). Then at runtime, method lookup has been fixed to correctly recurse in nested valueInterface wrappers and to find embedded interface fields in case of struct or pointer to structs. Fixes traefik#1515.
Configuration menu - View commit details
-
Copy full SHA for a725038 - Browse repository at this point
Copy the full SHA a725038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a2187a - Browse repository at this point
Copy the full SHA 3a2187aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 050378d - Browse repository at this point
Copy the full SHA 050378dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ded0780 - Browse repository at this point
Copy the full SHA ded0780View commit details
Commits on Feb 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 34ae1b6 - Browse repository at this point
Copy the full SHA 34ae1b6View commit details
Commits on Feb 28, 2023
-
Do not process receiver value in call
The receiver is already processed at method resolution and in genFunctionWrapper. Removing redundant processing in call fixes handling of variadic method, simplifies the code and makes it faster. With this commit, it is now possible to run coraza-waf plugin in traefik.
Configuration menu - View commit details
-
Copy full SHA for 7c2e5d6 - Browse repository at this point
Copy the full SHA 7c2e5d6View commit details
Commits on Mar 6, 2023
-
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 536019f - Browse repository at this point
Copy the full SHA 536019fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 708fbd6 - Browse repository at this point
Copy the full SHA 708fbd6View commit details -
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 36418b7 - Browse repository at this point
Copy the full SHA 36418b7View commit details -
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a65f9d4 - Browse repository at this point
Copy the full SHA a65f9d4View commit details -
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0505594 - Browse repository at this point
Copy the full SHA 0505594View commit details -
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1952a76 - Browse repository at this point
Copy the full SHA 1952a76View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.