Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve implicit destination #19

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

mikasdo
Copy link
Contributor

@mikasdo mikasdo commented Aug 8, 2023

In case there are more than 1 desstination candidates, pick the child…-most one, by discarding any candidate that is a superclass of another candidate.

example:
Generic inputRequiring class: AClass
Some feature specific class that inherits from generic: FeatureAClass

When producing "A"

  • Before: storyflow would init AClass
  • After: storyflow will init FeatureAClass

…-most one, by discarding any candidate that is a superclass of another candidate.
@mikasdo mikasdo requested a review from a team as a code owner August 8, 2023 18:59
@mikasdo mikasdo merged commit f1f3fbd into master Aug 10, 2023
1 check passed
@mikasdo mikasdo deleted the improve-implicit-destination branch August 10, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants