Send also the old state to the onStateChanged() callback

[riclage]

Problem

Listeners of the onStateChanged() callback cannot know the previous state the behavior was in. Knowing the old state is useful to perform one time operations.

For example, while the new state isSTATE_DRAGGING the onStateChanged() callback will be called several times and there is no way of knowing where it came from before without caching the value externally. But we might be interested in performing an action only when the state is changing from STATE_COLLAPSED to STATE_DRAGGING.

Solution

We add the param oldState to the callback.

[justasm]

Looks good, but it seems to be incorrect to say that onStateChanged may be called with STATE_DRAGGING multiple times, since setStateInternal explicitly checks whether mState == state.

Also, the same could be achieved by caching the latest value of newState externally, e.g.

class Callback : BottomSheetCallback {
  private var oldState: Int? = null
  override fun onStateChanged(v: View, newState: Int) {
    if (oldState == STATE_COLLAPSED && newState == STATE_DRAGGING) { /* .. */ }
    oldState = newState
  }
}

[riclage]

explicitly checks whether mState == state.

True. I missed that. Still, the problem applies. I updated the PR description.

Also, the same could be achieved by caching the latest value of newState externally, e.g.

Sure. That's how I'm currently doing. Just felt like it belonged in the lib instead.

[riclage]

@justasm Could you merge this?