Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect example code for 'builds' in README #438

Merged
merged 1 commit into from
Jan 7, 2017

Conversation

george-carlin
Copy link
Contributor

No description provided.

@Startouf
Copy link

Startouf commented Jan 2, 2017

The include was definitely missing but then you removed the alignment of the is_a?which feels less clean now.

Actually instead of the if else, although I usually don't like that, the builder is probable the only place where using a case syntax feels nicer

builds do |model, options|
  case model
  when Post; PostCell
  when Comment; CommentCell
  end
end

@apotonick
Copy link
Member

Agreeing with @Startouf - in builder, I'm also OK with a case statement, it looks better.

@george-carlin
Copy link
Contributor Author

fixed and rebased ;)

@apotonick apotonick merged commit 6d54b99 into trailblazer:master Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants