Revert all non-backwards compatible changes to create a reform 2.2.5 branch #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reform changes
* remove unused dummy-app files * remove gem file.lock * remove duplicated mini test and add gem file for 4.2 * add raise 3.2. translations * remove 3.1 as not supported * fix translation paths for rails 3.2 * stop circular dependency * remove more dummy app * cleanup format test * disable noisy warnings * restore format hack * clearly issues with format AM test. Skip for now
1. our minimum AM version is 3.2 so we can remove 3.0 code 2. update test_helper as railtie doesn’t run for tests 3. remove more of the dummy app 4. fix test expectation for rails 5 5. skip broken acceptance tests in rails 5
Fix unique validator issue
As it requires ActiveModel, it can’t run in pure Reform and should therefore be in reform-rails for time being
…ibutes params.merge! is deprecated in Rails 5
it doesn't pick up nested errors without providing a 2nd arg @form.artist.
clean up deprecation warnings, remove unnecessary app parts
* add test if only nested attribute is validated via AMV * fix validation result for nested forms with errors * remove duplicated line from form_test
Test Rails 5.2
…branch This includes all the recent master changes, except those that created non-backwards compatible changes, or changes based non-backwards compatible Reform 2.3 changes
We were previously getting this version on older ruby versions:
$ gem update --system
Updating rubygems-update
Fetching: rubygems-update-3.0.4.gem (100%)
ERROR: Error installing rubygems-update:
rubygems-update requires Ruby version >= 2.3.0.
ERROR: While executing gem ... (NoMethodError)
undefined method `version' for nil:NilClass
The command "gem update --system" failed and exited with 1 during .
This change limits us to less than version 3 of RubyGems. This should be
changed once we have dropped support for Ruby 2.2
Local gems can be configured with `bundle config local.reform`, so the ENV variable isn't needed. Furthermore this removes the needs for setting an ENV for gem source on Travis.
The symbol should be added and allow the I18n to pick up the correct message string.
|
@samstickland closing this since we fixed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is currently raised against trailblazer/reform-rails master, but obviously it should not be merged to master, but instead to a 0.1.8 branch
This includes all the recent master changes, except those that created non-backwards compatible changes, or changes based non-backwards compatible Reform 2.3 changes
It also includes experimental changes that fix the rails error handling. These will need to have tests added before it is merged.
There are still a few failing tests, probably as a result of introduced in the revert commit which need to be fixed. Furthermore there are many failing tests on travis that need to be fixed.