Clean up and restore some inherit_test code. #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `subject.validate` tests can be restored with some fairly minor syntax changes to be compatible with dry-validation.
|
Thanks for this. 👍 |
|
Cool, looking way better now! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
subject.validatetests can be restored with some fairly minor syntax changes to be compatible with dry-validation.There may be reasons to keep some of these tests commented-out that I'm not aware of.
The motivation for this clean-up is that I'm encountering some odd behaviour (possibly a bug, possibly a misunderstanding on my part) around inherited populators, and having a more thorough set of tests here is a prerequisite for me writing some tests to verify whether my issue is a bug or not.
cheers