Avoiding global configuration change #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BroiSatse This looks good to me. this commit seem unconfigured /unlinked to your github account. You can fix it before we merge it. |
|
@seuros - Fixed. |
|
@seuros Should we move this to the |
|
@BroiSatse Thank you |
|
@seuros @apotonick - Any chance on getting that merged in? I'd love to remove git reference from our Gemfile. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the cell example group is setting
ActionController::Base.allow_forgery_protectionto false, without setting it back to the original setting value. Whilefalseis rails default, we had agreed to usetruein our system as we use a lot of custom non jquery-ujs JS and we need to test they are reading CRSF token correctly and that before block has quite screwed us for some time.Tests should always avoid changing global objects (Well, we should avoid global objects, but can't help much for that) whenever possible.