Update waf script (so it can run on Python 3) #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like macOS fails now because libarchive has become keg-only (so configure script can't find it because it's not in usual location at /usr/local/XXX I've added an extra brew link command to force it to put libarchive in the expected locations.
I was going try EXPORT-method to work around macOS brew bug but forgot to remove this part of code before I committed in previous commit the 'brew link' way instead.
MacOS is problematic with libarchive and homebrew no longer installs libarchive as a non-keg-only package. This commit adds dirty hacks to try cope with the Keg-only libarchive. This hopefully makes travis tests still work and make user experience of installing traildb from source less of a hassle.
|
I merged this PR manually and squashed it. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wafscript that was in the repo was incompatible with Python 3.I pulled the latest waf (2.0.18) and updated it.