Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about Scaleway credentials #1419

Merged
merged 1 commit into from
May 12, 2019

Conversation

remyleone
Copy link
Contributor

Documentation Pull Request

Description

This PR adds a link towards the credentials page where the tokens are generated in the Scaleway console.

How Has This Been Tested?

Documentation Pull Request

@CLAassistant
Copy link

CLAassistant commented May 2, 2019

CLA assistant check
All committers have signed the CLA.

@remyleone
Copy link
Contributor Author

Should we add something in the documentation related to #1410 ?

@jackivanov
Copy link
Collaborator

No, no need to add anything about the modules. Although, we would need to change the link here to https://trailofbits.github.io/algo/cloud-scaleway.html which is coming from this PR

@remyleone remyleone force-pushed the docs_scaleway branch 2 times, most recently from e18ef26 to 9e0e700 Compare May 2, 2019 10:59
@remyleone
Copy link
Contributor Author

@jackivanov done.

@remyleone
Copy link
Contributor Author

remyleone commented May 3, 2019

@TC1977 done.

@jackivanov
Copy link
Collaborator

Thanks @remyleone! Could you please fix the conflicts and we'll merge it?

@remyleone
Copy link
Contributor Author

@jackivanov Done. Do you have further remarks?

roles/cloud-scaleway/tasks/prompts.yml Outdated Show resolved Hide resolved
roles/cloud-scaleway/tasks/prompts.yml Outdated Show resolved Hide resolved
@remyleone
Copy link
Contributor Author

@jackivanov Sorry it was a rebase mistake. It is fixed now.

@jackivanov jackivanov merged commit 826a2c5 into trailofbits:master May 12, 2019
iBringit added a commit to iBringit/algo that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants