Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaleway modules #1410

Merged
merged 2 commits into from
May 3, 2019
Merged

Scaleway modules #1410

merged 2 commits into from
May 3, 2019

Conversation

jackivanov
Copy link
Collaborator

@jackivanov jackivanov commented Apr 27, 2019

Description

Moves the scaleway tasks to the native modules, and disables unneeded prompt about the organisation name. ansible/ansible#55582 will be merged soon, but will not be back-ported as a feature to Ansible 2.7.

Motivation and Context

Closes #1401

How Has This Been Tested?

Deployed to Scaleway

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jackivanov jackivanov added the 1.1 label Apr 27, 2019
@jackivanov jackivanov added this to the 1.1 milestone Apr 27, 2019
@jackivanov jackivanov added this to To Do in Algo Development via automation Apr 27, 2019
@remyleone
Copy link
Contributor

@jackivanov Do you have suggestions about how to improve the native scaleway module? :)

@jackivanov
Copy link
Collaborator Author

@remyleone not really. Algo requires only a basic create-start-deploy functionality that is already in the module. boot_type was missing, but I've sent a PR to the upstream already

@jackivanov jackivanov merged commit 6b33d09 into master May 3, 2019
Algo Development automation moved this from To Do to Done May 3, 2019
@jackivanov jackivanov deleted the fix-1401 branch May 3, 2019 07:55
iBringit added a commit to iBringit/algo that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Move Scaleway to the native ansible modules
2 participants