Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cloud provider CloudStack #1420

Merged
merged 13 commits into from
Aug 15, 2019

Conversation

0xmilkmix
Copy link
Contributor

This new role allows to provision instances on Apache CloudStack providers like Exoscale.

I initially wanted to add a role specific for Exoscale but since they are using Apache CloudStack, better make it generic :)

Description

I added a new role cloud-cloudstack and modified the required files for inputs and configurations defaults.

Motivation and Context

I got an Exoscale gift-card to try their service at the latest Lausanne DevSecOps meetup. Since they advertised the non-US feature of their business, we discussed VPN and the like. What better use than add support for their cloud for this gift card?

How Has This Been Tested?

I only tested this CloudStack role on Exoscale. However, the only things to change would be in the user's $HOME/.cloudstack.ini file to specify the endpoint to use.

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0xmilkmix 0xmilkmix mentioned this pull request May 3, 2019
7 tasks
@0xmilkmix
Copy link
Contributor Author

it looks like Docker build failed on sudo -E apt-add-repository -y "ppa:wireguard/wireguard"" failed and exited with 1 during . Unfortunately, I cannot restart this job for it to pass

@jackivanov jackivanov changed the title clean commits from branch cloud-cloudstack w/ proper committer email/… New cloud provider CloudStack May 7, 2019
@TC1977
Copy link
Contributor

TC1977 commented May 10, 2019

I'd suggest editing readme.MD to reflect the new cloud provider. Specifically line 17, line 32, line 207. And probably deserves a mention in the CHANGELOG.md.

@jackivanov
Copy link
Collaborator

I'm not sure if we will merge this soon, as it's currently restricted to Exoscale only. We need to implement a task to discover region automatically

@0xmilkmix
Copy link
Contributor Author

I'm not sure if we will merge this soon, as it's currently restricted to Exoscale only. We need to implement a task to discover region automatically

I've not much time atm but I'll look into it in the following month.

@0xmilkmix
Copy link
Contributor Author

I'm not sure if we will merge this soon, as it's currently restricted to Exoscale only. We need to implement a task to discover region automatically

done in latest commits :)

@jackivanov jackivanov merged commit 3dc08c9 into trailofbits:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants