Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch errors should be shown when subsequent errors occur #1021

Closed
smoelius opened this issue Jan 17, 2024 · 1 comment
Closed

Fetch errors should be shown when subsequent errors occur #1021

smoelius opened this issue Jan 17, 2024 · 1 comment

Comments

@smoelius
Copy link
Collaborator

Fetch errors should be preserved here:

let _output = dylint_internal::cargo::fetch("dummy package")
.stable(true)
.build()
.args([
"--manifest-path",
&path.join("Cargo.toml").to_string_lossy(),
])
.logged_output(false)?;

Then, if a subsequent error occurs, the fetch error should be shown.

Example where a subsequent error could occur:

accessed
.into_iter()
.next()
.ok_or_else(|| anyhow!("Could not determined accessed subdirectory"))

smoelius added a commit to smoelius/dylint that referenced this issue Jan 19, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 19, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 19, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 19, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2024
@smoelius
Copy link
Collaborator Author

Fixed by #1025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant