Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo::Builder::quiet is too coarse #1014

Closed
smoelius opened this issue Jan 12, 2024 · 1 comment
Closed

cargo::Builder::quiet is too coarse #1014

smoelius opened this issue Jan 12, 2024 · 1 comment

Comments

@smoelius
Copy link
Collaborator

quiet prevents "header" messages:

if !self.quiet {
// smoelius: Writing directly to `stderr` prevents capture by `libtest`.
let message = format!("{} {}", self.verb, self.description);

quiet also prevents constructed commands from writing to stderr:
if self.quiet {
command.stderr(Stdio::null());
}

In dylint/src/metadata/cli/mod.rs, we don't use quiet because we want allow writing to stderr:
// smoelius: Since stdout and stderr are captured, there is no need to use `.quiet(true)`.
let _output = dylint_internal::cargo::fetch("dummy package")

But this then creates unwanted "header" messages.

smoelius added a commit that referenced this issue Jan 17, 2024
Bandaid until we come up with a better API for #1014.
smoelius added a commit that referenced this issue Jan 17, 2024
Bandaid until we come up with a better API for #1014.
smoelius added a commit to smoelius/dylint that referenced this issue Jan 19, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 19, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 19, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 20, 2024
smoelius added a commit to smoelius/dylint that referenced this issue Jan 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2024
@smoelius
Copy link
Collaborator Author

Fixed by #1025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant